Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size of cq could be wrong (?) #17

Open
d2gr opened this issue Sep 5, 2022 · 2 comments · May be fixed by #18
Open

Size of cq could be wrong (?) #17

d2gr opened this issue Sep 5, 2022 · 2 comments · May be fixed by #18

Comments

@d2gr
Copy link

d2gr commented Sep 5, 2022

Hello, I see that in this repo the size of the cq ring is using uint32Size instead of the CompletionQueueEntry's size. For reference, in liburing they use CompletionQueueEntry.

Your code

iouring-go/mmap.go

Line 77 in b1dc8dd

cq.size = params.CQOffset.Cqes + params.CQEntries*uint32Size

liburing:
https://github.com/axboe/liburing/blob/a71d56ef3259216739677473ddb17ad861c3a964/src/setup.c#L29

size = sizeof(struct io_uring_cqe);
...
cq->ring_sz = p->cq_off.cqes + p->cq_entries * size;
@Iceber
Copy link
Owner

Iceber commented Sep 5, 2022 •
edited

@d2gr Thanks, it does seem to be a serious bug.

Looks like I need to re-review this project,and start the development(alpha) of iouring-net.

@Iceber Iceber linked a pull request Sep 5, 2022 that will close this issue
Open
@kant777
Copy link

kant777 commented Apr 13, 2023

is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix mmap the CompletionQueueEvent Iceber/iouring-go
3 participants
@Iceber @kant777 @d2gr