Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chain methods | PHPUnit test files #1

Merged
merged 2 commits into from Sep 17, 2014

Conversation

ffreitasit
Copy link

No description provided.

@jmalloc
Copy link
Contributor

jmalloc commented Sep 17, 2014

Hey, thanks for the PR :) I'm happy to add the fluent interface into the next tag, but could you please revert the changes to .gitignore (this should go in your global .gitignore file), PackageInfo (this will be bumped when a new version is tagged), and the PHPUnit related stuff.

This project uses Archer, so to execute the tests you can just run vendor/bin/archer from the repository root. I'll make sure to add a note about that to the README on all our projects.

@ffreitasit
Copy link
Author

Ok, I will revert the change at .gitignore file.
But I have two points:

  1. If the PackageInfo file will be filled at the next version, this file should be ignored by git, right?
  2. You extends the PHPUnit class in your test, so for better development I think the phpunit/phpunit entrance must exists inside composer.json.
class PasswordGeneratorTest extends PHPUnit_Framework_TestCase

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3162a66 on ffreitas-br:develop into ef3a672 on IcecaveStudios:develop.

@jmalloc
Copy link
Contributor

jmalloc commented Sep 17, 2014

You're right, PHPUnit is technically a dependency, but because of the way Archer works at the moment the version pulled in by composer wont be used anyway so at this point it just takes longer to install dependencies for no real benefit. This is problem we've discussed before and once we change Archer and our internal tooling we'll correct this across all the packages.

In regards to PackageInfo it's not generated, but since we use git-flow our procedure is to bump the version in the release branch before the tag is created.

jmalloc added a commit that referenced this pull request Sep 17, 2014
Allow chain methods | PHPUnit test files
@jmalloc jmalloc merged commit 8c6171e into icecave:develop Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants