Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching the role throws an Exception in TYPO3 v8 #21

Open
denislorch opened this issue Jan 28, 2021 · 1 comment
Open

Switching the role throws an Exception in TYPO3 v8 #21

denislorch opened this issue Jan 28, 2021 · 1 comment

Comments

@denislorch
Copy link

The RoleSwitcher::switchRoleAction() method throws an exception because the \TYPO3\CMS\Core\Http\NullResponse class is not available in TYPO3 v8, but in TYPO3 v9/10.
This commit breaks it.

@baschny
Copy link

baschny commented Jan 28, 2021

As a suggestion: adding a test for this class would avoid this kind of incompatibility to slip in a patch level release. Either keep it compatible with v8 and v10 or drop support for v8 (in composer.json). As "3.1.0-3.1.2" are already tagged with "compatible with 8/9/10", it would be smoother if it could be reestablished in a "3.1.3", and break it in the next minor (3.2.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants