Do not manually set $_GET parameter in form data providers

[o-ba]

The code added with a137775 should be removed again as it leads to unreliable behaviour in the backend, based on record state (e.g. having inline children or not). See e.g. https://github.com/TYPO3/typo3/blob/v11.5.27/typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php#L150

[IchHabRecht]

Hi @o-ba,

Would you mind to describe the issue you have in the backend with that patch?

[o-ba]

Sure. The problem basically is that there are a view places in core, which check for $_GET['id']. One of them is the BackendConfigurationManager. We're for example using the manager in a custom LinkHandler, where we fetch the full TypoScript config. So depending on the content element loaded - e.g. whether it is a inline relation or not (https://github.com/IchHabRecht/content_defender/blob/main/Classes/Form/FormDataProvider/TcaColPosItems.php#L50) - the resolved TypoScript config differs due to the resolved current page id. Without this patch, the page id in this example will always be the same.

[IchHabRecht]

Hi @o-ba,

Thank you for your update. Unfortunately I'm not able to verify the problem with the given information. I would need some steps how to reproduce a problem to be able to solve this. As the revert would reintroduce #91 I won't revert it a this point.