Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #3404] macro escaping logs incorrect warning for $$ escapes #1149
This issue has been migrated from Redmine: https://dev.icinga.com/issues/3404
Created by abgandar on 2012-10-28 17:08:48 +00:00
In my icinga.log file, I keep getting these messages:
I traced it back to the expansion of the following check command copied straight from the example commands.cfg file provided with Icinga:
It seems the '$$' are correctly escaped into a single '$' in the command line that is executed, but there still is a warning logged each time the $$ is encountered. This should not happen as the command line is correct and there is no reason for a warning to appear.
Here is the relevant output from the debug log illustrating the situation:
[1351442252.937270] [2048.1] [pid=67924] **** BEGIN MACRO PROCESSING *****
2012-10-29 18:09:49 +00:00 by mfriedrich f78e443
Updated by mfriedrich on 2012-10-29 16:57:05 +00:00
seems i was not really awake when fixing #3397
the logic on hitting a macro error is a bit screwed up, so once detecting an error, it could also be the case of an escaped $ - but rather then rewriting that logic now, please try the attached patch instead.
Updated by mfriedrich on 2012-10-29 19:53:08 +00:00
ok, thx for testing. as you've seen there's an 1.8.2 already planned to address various ido and classic ui issues, to be released somewhere in november then (when ricardo is back again too).