Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #3467] Acknowledge send notification checkbox variable #1175

Closed
icinga-migration opened this issue Nov 27, 2012 · 17 comments
Closed
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Nov 27, 2012

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3467

Created by TheCry on 2012-11-27 07:24:54 +00:00

Assignee: crfriend
Status: Resolved (closed on 2013-01-16 21:35:04 +00:00)
Target Version: 1.9
Last Update: 2014-12-08 09:27:52 +00:00 (in Redmine)


It will be a nice to have the possibility to set the checkbox for the acknowledge "send notification" checked or unchecked as default parameter in the cgi.cfg.
Like the the checkbox "PERSISTENT ACKNOWLEDGEMENT COMMENTS"

# PERSISTENT ACKNOWLEDGEMENT COMMENTS
# This options determines whether the initial state of the
# checkbox "Persistent Comment:" for service and host problem
# acknowledgements is checked or unchecked

persistent_ack_comments=0

More Infos in the forum: http://www.monitoring-portal.org/wbb/index.php?page=Thread&threadID=27320

Changesets

2012-12-11 23:38:07 +00:00 by crfriend a74dee8

classic ui: Implement #3467, "set_ack_notifications"

refs: #3467

This commit implements proposed feature #3467 from "TheCry" to tick
or untick the "Send Notification" checkbox in the Acknowledge Problem
dialog.  The default behaviour is set to leave the checkbox ticked
thereby sending notifications when a problem is acknowledged and
preserving the original behaviour.

Thanks to Ricardo for the suggestion of using "set_{option}" as
syntax.

2012-12-18 15:58:38 +00:00 by ricardo 96e766b

classic-ui: changed "set_ack_notifications" to "send_ack_notifications" #3467

refs: #3467

Changed var name to "send_ack_notifications" and removed code which
isn't needed anymore.

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 28, 2012

Updated by mfriedrich on 2012-11-28 15:11:51 +00:00

  • Status changed from New to Assigned
  • Assigned to changed from mfriedrich to ricardo
  • Target Version set to 1.9
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 28, 2012

Updated by mfriedrich on 2012-11-28 15:11:59 +00:00

  • Project changed from Core, Classic UI, IDOUtils to 19
  • Category deleted Acknowledgements
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 7, 2012

Updated by crfriend on 2012-12-07 00:01:19 +00:00

The addition of #3476 (which see) reflects a usability issue, and, ultimately, a QA issue. These are important where the Icinga suite will be used in a wide variety of circumstances, some of which will likely be unanticipated by the developers (who are human after all and not prescient nor omniscient). Ideally, I believe, there should be a "cgi.cfg" declaration for almost every tick-box in the "Classic" CGIs.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 10, 2012

Updated by ricardo on 2012-12-10 09:52:59 +00:00

  • Assigned to changed from ricardo to crfriend
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 11, 2012

Updated by crfriend on 2012-12-11 18:18:26 +00:00

  • Category set to 43
  • Done % changed from 0 to 50

The code for this is done, next step will be to bundle it up, commit it properly, and submit a doc change request..

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 11, 2012

Updated by mfriedrich on 2012-12-11 18:48:23 +00:00

i am not entirely convinced that the bloat of config options now arising do make sense, or if this usability issue can be solved better (adding lots of config options for checkboxes for cmd.cgi will make others ask for more cgis to have the defaults, etc).

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 11, 2012

Updated by ricardo on 2012-12-11 20:06:23 +00:00

I wanted to get some structure into cgi.cfg anyway. I think we should do this for cmd.cgi because this is the one you you trigger external actions with, and there it would be handy to get more control on the checkboxes. But I also don't want to add an option for every cgi.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 11, 2012

Updated by mfriedrich on 2012-12-11 20:11:21 +00:00

  • Subject changed from Acknowlede send notification checkbox variable to Acknowledge send notification checkbox variable

just saying, depending on the maintenance level of such config options, it should be wisely chosen. for resolving the issue, there's a similarity amongst all those. So either a config prefix (like authorized_for_....) might be useful, or some sort of matrix to en/disable values.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 11, 2012

Updated by crfriend on 2012-12-11 23:46:25 +00:00

  • Done % changed from 50 to 80

I was a bit broad when I suggested "most all" tick-boxes should get a configuration option, but I believe that where there are instances where individual administrators who wish to change the default behaviours make sense they should be allowed to do so without resorting to hacking the code. As far as bloat goes, and I am sensitive to that problem, there are currently 48 options set in the cgi.cfg.in file in my sample-config directory, counting the one for this issue, and in a quick pass through most of the cmd.cgi windows I don't see many more off the top of my head that could warrant a config option (save for whether to schedule downtime for child hosts by default when scheduling a parent).

Now, I agree that some form of management of what gets a config option and what doesn't is warranted, and I suspect that some of that could be semi-automated. I also agree that the option names should be standardised (and are, in large part) in how they're used (this is how I arrived at the "use_{CGI-tickbox-name}" arrangement; however, following a discussion with Ricardo I adopted his notion of "set_{option}" instead as being less ambiguous.

In any event, pushed to cfriend/cgi as commit a74dee8. Please test.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 14, 2012

Updated by crfriend on 2012-12-14 12:16:53 +00:00

  • Status changed from Assigned to Feedback
  • Done % changed from 80 to 100

Coded, committed, and ready for testing. Change to docs on approval for merge.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 19, 2012

Updated by ricardo on 2012-12-19 12:50:13 +00:00

in current 'dev/cgis'

renamed var to "send_ack_notifications" cause in the code and the cgi param are called "send_notifications"

Thanks Carl

please test

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 19, 2012

Updated by ricardo on 2012-12-19 12:50:24 +00:00

  • Status changed from Feedback to 7
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 20, 2012

Updated by crfriend on 2012-12-20 01:04:11 +00:00

Issue #3467 has been updated by ricardo.

in current 'dev/cgis'

renamed var to "send_ack_notifications" cause in the code and
the cgi param are called "send_notifications"

In Changelog please be sure to reflect the correct (new)
configuration declaration name. As it stands, it looks like
it has my original syntax of "set_ack_notifications" which
has been changed to "send_ack_notifications". I am not
wedded to either one, but the history should be correct.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jan 16, 2013

Updated by mfriedrich on 2013-01-16 21:35:04 +00:00

  • Status changed from 7 to Resolved
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jan 16, 2013

Updated by crfriend on 2013-01-16 23:04:31 +00:00

On Wed, 16 Jan 2013, development@icinga.org wrote:

Issue #3467 has been updated by dnsmichi.

Status changed from Fixed to Resolved

For #3476 and #3467, should I submit a docs update with the revised
declaration names?

Cheers!

---------------------------------------------------------------------+
| Carl Richard Friend (UNIX Sysadmin) | West Boylston |
| Minicomputer Collector / Enthusiast | Massachusetts, USA |
| mailto:crfriend@rcn.com ---------------------
| http://users.rcn.com/crfriend/museum | ICBM: 42:22N 71:47W |

---------------------------------------------------------------------+

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jan 16, 2013

Updated by mfriedrich on 2013-01-16 23:07:00 +00:00

yep, please open issues in the docs tracker and put some text together. docs team will do the xml formatting.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:27:52 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 43 to Classic UI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.