Event rule config enhancement #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
event-rule-config-enhancement
branch
4 times, most recently
from
c40476a
to
8e16e7e
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
13 times, most recently
from
1c9054f
to
7ab548f
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
9 times, most recently
from
25b4a12
to
163112c
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
3 times, most recently
from
97018d5
to
4b1380c
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
5 times, most recently
from
3516123
to
babd436
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
3 times, most recently
from
3981ff8
to
dbc97ac
Compare
sukhwinder33445
requested changes
Apr 26, 2024
application/forms/EventRuleConfigElements/EscalationCondition.php
Outdated
Show resolved
Hide resolved
application/forms/EventRuleConfigElements/EscalationCondition.php
Outdated
Show resolved
Hide resolved
application/forms/EventRuleConfigElements/EscalationCondition.php
Outdated
Show resolved
Hide resolved
application/forms/EventRuleConfigElements/EscalationCondition.php
Outdated
Show resolved
Hide resolved
application/forms/EventRuleConfigElements/EscalationRecipient.php
Outdated
Show resolved
Hide resolved
application/forms/EventRuleConfigElements/EscalationRecipient.php
Outdated
Show resolved
Hide resolved
raviks789
force-pushed
the
event-rule-config-enhancement
branch
2 times, most recently
from
04d545c
to
4101ce6
Compare
sukhwinder33445
requested changes
Apr 29, 2024
| $buttonsWrapper->add( | ||
| [$eventRuleConfigSubmitButton, $discardChangesButton, $deleteButton] | ||
| ); | ||
| $buttonsWrapper->add([$eventRuleConfigSubmitButton, $discardChangesButton, $deleteButton]); |
There was a problem hiding this comment.
Please use addHtml wherever possible.
There was a problem hiding this comment.
I would use add() here as $discardChangesButton could be null. But addHtml could be use in PR #170, as you do not need that button.
| @@ -283,7 +281,7 @@ public static function createFilterString(Filter\Rule $filters): string | |||
|
|
|||
| $filterStr = QueryString::render($filters); | |||
|
|
|||
| return ! empty($filterStr) ? $filterStr : ''; | |||
| return ! empty($filterStr) ? rawurldecode($filterStr) : ''; | |||
There was a problem hiding this comment.
Why is this change required now?
There was a problem hiding this comment.
This is to store and display certain special characters like '/' as it is instead of in its url encoded form. This was earlier done in setObjectString method in EventRuleObjectFilter.
Comment on lines
296
to
301
| $config = iterator_to_array( | ||
| Rule::on(Database::get()) | ||
| ->withColumns(['id']) | ||
| ->filter(Filter::equal('id', $ruleId)) | ||
| ->first() | ||
| ); |
There was a problem hiding this comment.
The iterator_to_array method is not required here, and please fetch only the required columns. You can use Connection::FetchOne() to get the result as an array.
There was a problem hiding this comment.
You do not need to mention the columns, as by default only the columns from rule table will be fetched.
There was a problem hiding this comment.
Yes, but you don't want all rule columns.
There was a problem hiding this comment.
That is true as well
application/forms/EventRuleConfigElements/EscalationCondition.php
Outdated
Show resolved
Hide resolved
application/forms/EventRuleConfigElements/EscalationCondition.php
Outdated
Show resolved
Hide resolved
application/forms/EventRuleConfigElements/EventRuleConfigFilter.php
Outdated
Show resolved
Hide resolved
application/forms/EventRuleConfigElements/EventRuleConfigFilter.php
Outdated
Show resolved
Hide resolved
application/forms/EventRuleConfigElements/EventRuleConfigFilter.php
Outdated
Show resolved
Hide resolved
raviks789
force-pushed
the
event-rule-config-enhancement
branch
6 times, most recently
from
bfcbbcf
to
6c81474
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
6 times, most recently
from
513d3a4
to
6243671
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
from
6243671
to
c2dc61d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single form for event rule configuration.
Blocked by Icinga/icingaweb2#5190