Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9172] Add "ldap" CheckCommand for "check_ldap" plugin #2963

Closed
icinga-migration opened this issue Apr 25, 2015 · 4 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Apr 25, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9172

Created by bouttier on 2015-04-25 04:21:09 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2015-04-25 11:40:39 +00:00)
Target Version: 2.3.6
Last Update: 2015-07-08 07:47:42 +00:00 (in Redmine)

Backport?: Already backported
Include in Changelog: 1

Done in PR #30

Changesets

2015-04-25 11:11:49 +00:00 by bouttier fb820f6

ITL: Add "ldap" CheckCommand

refs #9172

Signed-off-by: Michael Friedrich <michael.friedrich@gmail.com>

2015-04-25 11:35:59 +00:00 by mfriedrich afb70a2

ITL: Add missing 'ldap' command arguments

refs #9172

2015-04-25 11:36:32 +00:00 by mfriedrich d6f41a2

Update AUTHORS

refs #9172

2015-07-08 07:45:10 +00:00 by bouttier 949e626

ITL: Add "ldap" CheckCommand

refs #9172

Signed-off-by: Michael Friedrich <michael.friedrich@gmail.com>

2015-07-08 07:45:17 +00:00 by mfriedrich caf6e1f

ITL: Add missing 'ldap' command arguments

refs #9172

2015-07-08 07:45:47 +00:00 by mfriedrich 04ac7cc

Update AUTHORS

refs #9172
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 25, 2015

Updated by mfriedrich on 2015-04-25 11:37:14 +00:00

  • Category set to ITL
  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 2.4.0
  • Estimated Hours set to 1

Thanks.

Some notes from review:

  • ldap_attr was missing in the documentation
  • when adding a check command please ensure that all available options are added (call '--help')
  • always add the description field (we might expose that later on on the cli/api for proper command argument help)
  • ensure that default values are properly set as default values

I've modified the check command in that way, but kept that in a separate commit so you'll see what I mean.

Thanks for your contribution! :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 25, 2015

Updated by mfriedrich on 2015-04-25 11:40:39 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 27, 2015

Updated by mfriedrich on 2015-04-27 08:52:47 +00:00

  • Backport? changed from TBD to No
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 8, 2015

Updated by mfriedrich on 2015-07-08 07:47:42 +00:00

  • Target Version changed from 2.4.0 to 2.3.6
  • Backport? changed from No to Yes

It is safe to backport this into 2.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.