Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10903] GELF multi-line output #3805

Closed
icinga-migration opened this issue Dec 22, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Dec 22, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10903

Created by akrus on 2015-12-22 13:47:39 +00:00

Assignee: mariussturm
Status: Resolved (closed on 2016-08-09 07:55:04 +00:00)
Target Version: 2.5.0
Last Update: 2016-08-09 07:55:04 +00:00 (in Redmine)

Icinga Version: 2.4.1
Backport?: Not yet backported
Include in Changelog: 1

Hello!

We have an issue here with GELF multi-line output.

This dummy check:
vars.dummy_text = "Service status:\n123\n\321"
Looks in Icinga Web 2 as:
Service status:
123
321

but in Graylog we see:
message: Service status:
full_message: 123\n321

I think full_message should instead contain both message+full_message and with correct line breaks.

Attachments

Changesets

2016-08-09 07:51:17 +00:00 by (unknown) 451cd73

GelfWriter: Use raw CheckResult output for full_message attribute

fixes #10903

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2016

Updated by mfriedrich on 2016-01-11 13:17:53 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mariussturm

@marius

Please look into that thanks.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2016

Updated by mfriedrich on 2016-03-18 14:58:24 +00:00

Any updates? Thanks.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2016

Updated by mariussturm on 2016-03-18 22:56:54 +00:00

  • File added Screen Shot 2016-03-18 at 23.42.31.png

The problem is the use of 'CompatUtility::GetCheckResultLongOutput' for the GELF full_message field.
That methode is cutting and escaping the message what leads to a result users properly don't want. I tried a couple of variations but
for me the combination of:

short_message: as is right now (only first line + escaped)
full_message: raw CheckResult output

looks best in my opinion. I have appended a screenshot of that, (short_message: "Connection refused", full_message: "Connection refused\nHTTP CRITICAL - Unable to open TCP socket")
What do you think?

Here is the change for this:
mariussturm@37adc65

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2016

Updated by mariussturm on 2016-04-10 19:49:27 +00:00

Looks like nobody has objections.
@dnsmichi could you please review and merge the branch `10903-gelf-multi-line`?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2016

Updated by mfriedrich on 2016-08-09 07:51:10 +00:00

  • Target Version set to 2.5.0

Didn't find that feature branch over at git.icinga.org therefore I fetched the github patch and applied it.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2016

Updated by Anonymous on 2016-08-09 07:55:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 451cd73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.