Perfdata: missing support for ranges in warning/critical thresholds

[tjapa]

Describe the bug

The InfluxdbWriter is ignoring the perfdata result from script check_snmp with two ranges for warning and critical thresholds.

[2021-10-14 14:14:20 +0000] warning/InfluxdbWriter: Ignoring invalid perfdata for checkable 'TESTE-HOST!PING_LOSS_RTT' and command 'check_bpinger_lossrtt' with value: ping-rtt=9120;@1:3,@10000:50000;@4:99,@60000:100000

To Reproduce

The check_bpinger_loss_rtt is a wrapper for check_snmp (Nagios plugin).

Basically, the check_snmp is being called like (ignoring some arguments):

./check_snmp -w @1:3,@10000:50000 -c @4:99,@60000:100000 -l ping-loss,ping-rtt

Output:

SNMP OK - ping-loss 0 ping-rtt 6410 | ping-loss=0;@1:3,@10000:50000;@4:99,@60000:100000 ping-rtt=6410;@1:3,@10000:50000;@4:99,@60000:100000

When a running with only one range for critical and warning threshold, the problem seems gone.

./check_snmp -w @1:3 -c @4:99 -l ping-loss,ping-rtt

Output:

SNMP OK - ping-loss 0 ping-rtt 8860 | ping-loss=0;@1:3;@4:99 ping-rtt=8860;@1:3;@4:99

My Environment

I'm running the icinga/icinga2 2.13.1 4944f0bc0f67 docker image.

System information:
Platform: Debian GNU/Linux
Platform version: 10 (buster)
Kernel: Linux
Kernel version: 4.9.0-16-amd64
Architecture: x86_64

Build information:
Compiler: GNU 8.3.0
Build host: 4674da227710
OpenSSL version: OpenSSL 1.1.1d 10 Sep 2019

Disabled features: debuglog elasticsearch gelf graphite icingadb ido-mysql mainlog opentsdb perfdata syslog
Enabled features: api checker ido-pgsql influxdb notification

[LordHepipud]

Icinga for Windows plugins are also affected, as we support the Icinga plugin thresholds out-of-the-box for almost every plugin and argument.

https://icinga.com/docs/icinga-for-windows/latest/plugins/doc/10-Icinga-Plugins/

[julianbrost]

Looks like the original [Nagios plugin guidelines] seem to explicitly allow ranges for warn/crit:

warn and crit are in the range format (see the Section called Threshold and Ranges). Must be the same UOM

But looking at the icinga2 code, seems like support for this was never implemented.

[Al2Klimov]

Colleagues, what about just letting the parsing succeed for now, so we get the value and can write it, but not necessarily the thresholds, yet?

[RincewindsHat]

yes, please do that at least.