Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow special chars in customvar and make it case natural #66

Merged
merged 19 commits into from Feb 15, 2022

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@sukhwinder33445
Copy link
Contributor Author

The bug

You can see the detailed description of the bug here.

All the given examples in the issue (linked above) are working now and we found more issues which also have been fixed.

Now you can add as many special characters as you want to a customvar. For example, you can name your customvar MyVaR, myVar 1, myV$r 1, or <1|my- -v$r|1>.

Screenshots

Case-sensitive

case_sensitive

Space between chars is allowed

Space_between_chars

And even more

allow_even_more

@sukhwinder33445 sukhwinder33445 force-pushed the fix/invalid-processing-of-customvar-62 branch from e774db1 to 84c4e51 Compare July 5, 2021 14:28
@sukhwinder33445 sukhwinder33445 changed the title Fix/invalid processing of customvar 62 Allow special chars in customvar and make it case neural Nov 12, 2021
@sukhwinder33445 sukhwinder33445 changed the title Allow special chars in customvar and make it case neural Allow special chars in customvar and make it case natural Nov 12, 2021
@nilmerg nilmerg added this to the v1.2.0 milestone Dec 14, 2021
@nilmerg nilmerg force-pushed the fix/invalid-processing-of-customvar-62 branch from 84c4e51 to 6c97bfb Compare February 11, 2022 09:32
@cla-bot cla-bot bot added the cla/signed label Feb 11, 2022
@nilmerg nilmerg force-pushed the fix/invalid-processing-of-customvar-62 branch from 6c97bfb to 0cd584d Compare February 11, 2022 11:18
@nilmerg nilmerg force-pushed the fix/invalid-processing-of-customvar-62 branch from 9be0ea2 to 8e779f7 Compare February 14, 2022 14:16
@nilmerg nilmerg force-pushed the fix/invalid-processing-of-customvar-62 branch from 8e779f7 to b8bdae0 Compare February 15, 2022 14:11
@nilmerg nilmerg added bug Something isn't working ref/IP labels Feb 15, 2022
@nilmerg nilmerg merged commit 6e4919d into master Feb 15, 2022
@nilmerg nilmerg deleted the fix/invalid-processing-of-customvar-62 branch February 15, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed ref/IP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dimension slicing by custom data field names with certain characteristics cause failures or stacktrackes
3 participants