Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10892] Wrong mask for FileCache's temp directory #2217

Closed
icinga-migration opened this issue Dec 18, 2015 · 4 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Dec 18, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10892

Created by kobmaki on 2015-12-18 20:01:22 +00:00

Assignee: (none)
Status: Resolved (closed on 2015-12-21 23:55:14 +00:00)
Target Version: 2.1.1
Last Update: 2015-12-21 23:55:14 +00:00 (in Redmine)


The creation of a tmp directory has a wrong effective mask.
The File "library/Icinga/Web/FileCache.php" contains the error.
It creates an effective mask of 1354 instead of 0750 (still incorrect).

The patch fix it to the right mask of 01750, so that the owner can write, group can read, others are forbidden and marks it as as tmp directory.

You can verify the misbehavior under linux with the following script (wrong-right-mask.php):

run it by

php wrong-right-mask.php

verify the directories by

wrong mask:

stat wrong.0750 | grep Gid
Access: (1354/d-wxr-xr-T) Uid: ( 999/ monmaki) Gid: ( 999/ monmaki)

and the right on:

stat right.01750|grep Gid
Access: (1750/drwxr-x--T) Uid: ( 999/ monmaki) Gid: ( 999/ monmaki)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 18, 2015

Updated by kobmaki on 2015-12-18 20:34:51 +00:00

GIthub pullrequest is

#56

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 19, 2015

Updated by kobmaki on 2015-12-19 05:37:03 +00:00

The patch was updated to make clear that the 01750 is from math type oct.
octdec('01750')

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 21, 2015

Updated by elippmann on 2015-12-21 23:55:00 +00:00

  • Subject changed from Web-FileCache-wrong-mask-implementation to Wrong mask for FileCache's temp directory
  • Status changed from New to Assigned
  • Assigned to set to elippmann
  • Target Version set to 2.1.1

Fixed w/ 3c47436.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 21, 2015

Updated by elippmann on 2015-12-21 23:55:14 +00:00

  • Status changed from Assigned to Resolved
  • Assigned to deleted elippmann
  • Done % changed from 0 to 100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.