New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #13381] Allow to configure the default listen address for the CLI command web serve #2631

Closed
icinga-migration opened this Issue Dec 2, 2016 · 4 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Member

icinga-migration commented Dec 2, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13381

Created by kobmaki on 2016-12-02 08:40:37 +00:00

Assignee: kobmaki
Status: Resolved (closed on 2016-12-13 11:06:33 +00:00)
Target Version: 2.4.0
Last Update: 2016-12-13 11:06:33 +00:00 (in Redmine)


Running the icingaweb2 as a standalone server, you have to add the option for the socket.

It would be nice to add a parameter in the config.ini for the listen socket.

One possibility is to add in the global section the parameter for socket. Another one is to create a special section like "web" for the socket.

E.g. in the config.ini:

[web]
socket = "0.0.0.0:5688"

If the feature is accepted, more things have to be discuss. Then I will send the patch for this feature.

Attachments

Changesets

2016-12-13 11:05:25 +00:00 by kobmaki 93b7b11

Make default listen address for CLI command web serve configureable

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>

resolves #13381
@icinga-migration

This comment has been minimized.

Member

icinga-migration commented Dec 2, 2016

Updated by elippmann on 2016-12-02 14:03:49 +00:00

  • Status changed from New to Assigned
  • Assigned to set to kobmaki

Hi,

I like the idea. But I suggest to name the config section "standalone" and the option "listen".

Best regards,
Eric

@icinga-migration

This comment has been minimized.

Member

icinga-migration commented Dec 2, 2016

Updated by kobmaki on 2016-12-02 14:42:08 +00:00

  • File added 0001-Implement-the-feature-Application-Web-serve-config-13381.patch

Here is the patch for the feature.

To use the feature in the stand alone version you should add to the config.ini the section

[standalone]
listen = "0.0.0.0:5688"

After this, the icingacli web serve will listen on the defined port.
Take care, not to run this as root. Primary run it as unprivileged.

@icinga-migration

This comment has been minimized.

Member

icinga-migration commented Dec 13, 2016

Updated by elippmann on 2016-12-13 11:06:27 +00:00

  • Subject changed from Application, Web, serve, config.ini, socket configable to Allow to configure the default listen address for the CLI command web serve
  • Target Version set to 2.4.0
@icinga-migration

This comment has been minimized.

Member

icinga-migration commented Dec 13, 2016

Updated by kobmaki on 2016-12-13 11:06:33 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 93b7b11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment