Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Rename 'Check Source' to 'Command Endpoint' #3730

Closed
junglistikal opened this issue Mar 26, 2019 · 2 comments
Closed

[Suggestion] Rename 'Check Source' to 'Command Endpoint' #3730

junglistikal opened this issue Mar 26, 2019 · 2 comments

Comments

@junglistikal
Copy link

To be more consistent with the Icinga2 API, can 'Check Source' be renamed to 'Command Endpoint'. It would add a little less confusion to newcomers of Icingaweb2 who are creating their checks via API.

@dnsmichi
Copy link
Contributor

check_source is not necessarily the command endpoint. It may also originate from the local scheduler on this instance.

Also, check_source is the key provided by Icinga 2's API when querying for check results.

@nilmerg
Copy link
Member

nilmerg commented Apr 4, 2019

The term endpoint has a specific meaning while check source is more of a general term. And since Icinga/icinga2#2985 check_source gets the endpoint's name by default. (Implying that it may not be the command endpoint)

So I'd say we keep things as they are.

@nilmerg nilmerg closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants