Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTSTART seems not to be a native property for RRULE #39

Closed
nilmerg opened this issue Mar 29, 2023 · 4 comments · Fixed by #40
Closed

DTSTART seems not to be a native property for RRULE #39

nilmerg opened this issue Mar 29, 2023 · 4 comments · Fixed by #40
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nilmerg
Copy link
Member

nilmerg commented Mar 29, 2023

https://icalendar.org/iCalendar-RFC-5545/3-8-5-3-recurrence-rule.html only speaks of DTSTART when not directly referring to the RRULE properties. The examples shown also don't show it as such.

rrule.js seems to be able to cope with it, but I'd not be surprised if another library cannot. @yhabteab Please check if that's the case with the library you're using in the newest go project 😉

@nilmerg
Copy link
Member Author

nilmerg commented Mar 29, 2023

We've discussed this offline and the result is:

  • DTSTART must not be part of the RRULE definition when exporting using jsonSerialize()
    • It should be a separate entry in the array alongside rrule instead
  • This is because the go library we use doesn't support that property once a timezone is defined
  • The php library also has a problem with such

@nilmerg
Copy link
Member Author

nilmerg commented Mar 29, 2023

I'd suggest to store the start as start in DateTimeInterface::ATOM format. Once outside the RRULE it doesn't have any meaning and thus the DTSTART name is meaningless.

@yhabteab
Copy link
Member

I'd suggest to store the start as start in DateTimeInterface::ATOM format.

Why? We have introduced our own format last time.

@nilmerg
Copy link
Member Author

nilmerg commented Mar 29, 2023

Ah, nvm, didn't remember this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants