Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icingadb::db_password to be an optional parameter #378

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix icingadb::db_password to be an optional parameter #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion REFERENCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1927,10 +1927,12 @@ Default value: `'icingadb'`

##### <a name="-icingaweb2--module--icingadb--db_password"></a>`db_password`

Data type: `Icingaweb2::Secret`
Data type: `Optional[Icingaweb2::Secret]`

Password for IcingaDB database connection.

Default value: `undef`

##### <a name="-icingaweb2--module--icingadb--db_charset"></a>`db_charset`

Data type: `Optional[String]`
Expand Down
2 changes: 1 addition & 1 deletion manifests/module/icingadb.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,12 @@
class icingaweb2::module::icingadb (
String $package_name,
Enum['mysql', 'pgsql'] $db_type,
Icingaweb2::Secret $db_password,
Enum['absent', 'present'] $ensure = 'present',
Stdlib::Host $db_host = 'localhost',
Optional[Stdlib::Port] $db_port = undef,
String $db_name = 'icingadb',
String $db_username = 'icingadb',
Optional[Icingaweb2::Secret] $db_password = undef,
Optional[String] $db_charset = undef,
Optional[Boolean] $db_use_tls = undef,
Optional[String] $db_tls_cert = undef,
Expand Down
4 changes: 0 additions & 4 deletions spec/classes/icingadb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
let(:params) do
{
db_type: 'mysql',
db_password: 'foobar',
}
end

Expand Down Expand Up @@ -64,7 +63,6 @@
'port' => 3306,
'database' => 'icingadb',
'username' => 'icingadb',
'password' => 'foobar',
'charset' => nil,
'use_tls' => nil,
},
Expand All @@ -76,7 +74,6 @@
let(:params) do
{
db_type: 'pgsql',
db_password: 'foobar',
}
end

Expand Down Expand Up @@ -123,7 +120,6 @@
'port' => 5432,
'database' => 'icingadb',
'username' => 'icingadb',
'password' => 'foobar',
'charset' => nil,
'use_tls' => nil,
},
Expand Down