Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTM integration #9

Open
RemDelaporteMathurin opened this issue Jun 29, 2023 · 5 comments
Open

HTM integration #9

RemDelaporteMathurin opened this issue Jun 29, 2023 · 5 comments

Comments

@RemDelaporteMathurin
Copy link

Hi HyPAT team!

I think some of the hydrogen transport properties in HyPAT could be corrected by integrating it with HTM.

HTM is an open source database of H properties (@FuerstT and @natethegreatINL have been contributing).
It can be used to plot Arrhenius properties with matplotlib by filtering the database.

I think it would help refactoring HyPAT and would reduce the line count slightly.

Let me know what you guys think

I'm happy to come up with a PR if that's of interest

@FuerstT
Copy link
Collaborator

FuerstT commented Jul 5, 2023

Great idea @RemDelaporteMathurin!

If you can please start a PR and work with @natethegreatINL on integration, that would be an excellent upgrade to the current overview plots tab.

@natethegreatINL
Copy link
Contributor

@RemDelaporteMathurin, I would be happy to help with this integration, is there a place you would like me to get started?

@RemDelaporteMathurin
Copy link
Author

@RemDelaporteMathurin, I would be happy to help with this integration, is there a place you would like me to get started?

I'll have a look in the code to see where this would come into play

@RemDelaporteMathurin
Copy link
Author

Right. I managed to fiddle a bit with the source code. Not very familliar with tkinter...

I've managed to have a proof of concept of how to integrate HyPAT with HTM.

Here's an example for just tungsten, aluminium and Inconel 600:

image

Note: the graphs are totally decoupled from the left column here.

I can push the code for this prototype to a branch if you guys are interested.

On a side note: I would avoid using xlsx files for several reasons:

  • They can only be opened with the right software (Excel, Libreoffice..)
  • They cannot be visualised in version control (because they are binary files)

Since all of the xlsx files are simple 2 columns data, I would instead suggest using .csv files that can be opened with any text reader (and Excel!) and are much easier to work with from a programmatic point of view (can be opened with pandas or numpy in one line of code).

Happy to discuss this further.

@RemDelaporteMathurin
Copy link
Author

EDIT: I added a bunch of materials.
Now the database sometimes contains several entries for one material.
In my proof of concept, I just chose the first entry for the material.

I'll leave you guys choose what to do:

  • Option 1: choose from an exact reference
  • Option 2: take the mean of the properties in the database for this material
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants