New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#201 - Null-Safety support #209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please merge @florent37 |
This works - please fix @brenodt
|
@7flash Thanks for the review, fix made. |
wow thanks a lot guys, I merge it ! |
I will publish a new verison <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to bring null-safety support to the package - as per #201 request.
The approach taken was to change as little as possible in terms of logic:
@required
tag was used were replaced withrequired
keyword and became non-nullable.On
slider.dart
andrange_slider.dart
, theonPanUpdate
method declarations have had to be updated, ascontext.findRenderObject()
no longer yields aRenderBox
(
lib/src/widget/slider.dart:143
,lib/src/widget/range_slider.dart:168
). Instead, the tap position is now usingDragUpdateDetails.localPosition
.Secondly, I couldn't ascertain how to regenerate the
lib/generated/i18n.dart
file, but I don't see it being used anywhere. Maybe it should be dropped?@florent37 I hope this helps bringing the package to Null-Safety, let me know if you think I should change anything. Thanks in advance!