Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 13 #28

Merged
merged 2 commits into from Sep 21, 2021
Merged

Xcode 13 #28

merged 2 commits into from Sep 21, 2021

Conversation

Patrick-Kladek
Copy link
Owner

Description

Update to Xcode 13 and fix some new warnings along the way.

Tasks

  • Apply recommended warnings
  • Change Protocols to conform to AnyObject instead of class

Infos For Reviewer

There are still 2 warnings in UserDefaults+Keys. Seems to be an issue with SwiftLint though:
Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

@Patrick-Kladek Patrick-Kladek self-assigned this Sep 21, 2021
@Patrick-Kladek Patrick-Kladek marked this pull request as ready for review September 21, 2021 13:34
Copy link
Contributor

@schwmi schwmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@schwmi schwmi merged commit a663697 into main Sep 21, 2021
@schwmi schwmi deleted the enhancement/Xcode13 branch September 21, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants