Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some parameters generate invalid HTTP request for UserInfo #255

Open
fogzot opened this issue Sep 25, 2019 · 6 comments
Open

Some parameters generate invalid HTTP request for UserInfo #255

fogzot opened this issue Sep 25, 2019 · 6 comments

Comments

@fogzot
Copy link

fogzot commented Sep 25, 2019

Specifing some parameters like ClientId or ClientSecret in UserInfoRequest result in a GET HTTP request with a body. This is wrong and is a problem, especially for applications hosted on services like Google Cloud that refuse to route GET/DELETE HTTP requests with a body.

Calling GetUserInfoAsync() with extra parameters should probably ingore them or throw an exception.

@leastprivilege
Copy link
Contributor

Will look into it for v5. Why are you setting those parameters?

@leastprivilege leastprivilege added this to the 5.0 milestone May 18, 2020
@fogzot
Copy link
Author

fogzot commented Jun 3, 2020

Sorry for the late response. It was an error in my code and I lost a lot of time before discovering that the generated request was "invalid". There is no real reason for calling GetUserInfoAsync() with extra parameters, that's why I suggested to ignore them or return an error.

@leastprivilege leastprivilege modified the milestones: 5.0, 5.x Jan 13, 2021
@leastprivilege leastprivilege modified the milestones: 5.x, 6.x Dec 28, 2021
@leastprivilege
Copy link
Contributor

feel free to PR

@brockallen
Copy link
Member

What's our status on this request?

@josephdecock
Copy link
Contributor

I had some feedback on the linked PR, and then it was closed by the submitter.

@josephdecock
Copy link
Contributor

As to what we do with this now, I'm not sure, but I don't think this is a high priority. Maybe keep the issue around in case someone wants to take another crack at it?

@josephdecock josephdecock removed their assignment Feb 21, 2024
@josephdecock josephdecock added this to the Future milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants