signoutPopupCallback method missing

[ADCJustinH]

Issue / Steps to reproduce the problem

This may be a misunderstanding of intent but it seems that in oidc-client js the popup signout methods are missing. I was able to get the client working for popup signin my Cordova app (thanks for including those changes btw) but on signout the popup window does not close automatically. I couldn't find a sample using the signoutPopup method so perhaps it does work and I'm just doing something wrong.

Looking through the code I found the callback that was bound to the popup window and I made this work by including this code in my signout callback page:

  if(window.opener && window.opener.hasOwnProperty('popupCallback_undefined')){
            window.opener.popupCallback_undefined(window.location.href);
        }

obviously this is not how it was meant to be used and using undefined instead of id/state may lead to trouble later but it works for now.

Is there an example/doc I missed or is the signout equivalent to

var mgr = new Oidc.UserManager();
mgr.signinPopupCallback();

just missing as I suspect?

Thanks,
Justin

[brockallen]

Ok, I'll reexamine the APIs to see if this makes sense.

[brockallen]

I looked into this and you're absolutely right -- somehow I overlooked the signout popup code. I think I meant to remove it when I ported from oidc-client-manager, but the signoutPopup seems to have been sort of worked on but never properly completed (which I'm somewhat embarrassed by). ANyway, I worked on this some yesterday and added the signoutPopupCallback -- look at the updated sample and see if it works for you. You can test it with the npm release 1.3.0-beta.4.

[ravikatha]

Please add the method definition to the typescript definition file too.

[brockallen]

Please add the method definition to the typescript definition file too.

Done. I wasn't sure if TS allowed method overloading, so this was added:

        signoutPopupCallback(url?: string, keepOpen?: boolean): Promise<void>;
        signoutPopupCallback(keepOpen?: boolean): Promise<void>;

Is that legal TS?

[brockallen]

@ADCJustinH I know this was opened a while ago and you might not be in a position to test. I'll close this for now, and if you do ever get to the point of testing please let me know how it's working for you.