Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Could you add UserManagers revokeAccessToken() method to type definitions? #313

Closed
martinpritchardelevate opened this issue Apr 21, 2017 · 6 comments
Milestone

Comments

@martinpritchardelevate
Copy link

I currently have a scenario where this would be very useful.

@brockallen
Copy link
Member

A PR from you would be welcome :)

@figuerres
Copy link

i have also run into this, i want to help but i have not done a pr before, the online docs refer to making a branch and then using the branch to make a pr, but on the portal i do not see a web ui for making a branch, only for making a fork.
i am not sure if i am looking at the wrong thing or lack permissions or what....
if i find any other missing type definitions i would add them also so we cover as much as we can...

@figuerres
Copy link

PS: looks like the session change add / remove are not in the .d.ts file also.
i have them in my local copy to add to the revoke token if i can see how to get it in here for a pr

@brockallen
Copy link
Member

@figuerres
Copy link

@brockallen
thank you for responding, i read that page and it led me to this page https://help.github.com/articles/creating-a-pull-request/

on that page it says that i need to create a branch ? at least i think that is what it says...
sorry but i am new at this. i have a local copy in vs code that i have edited, i know that if i had my own repo i would publish to that.

i am just not sure how to push my edit back up to your repo as a branch to make into the pr.

@brockallen brockallen added this to the 1.4.0 milestone Sep 23, 2017
@brockallen
Copy link
Member

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants