Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Security vulnerabilities in dependency "jsrsasign" #743

Closed
dotnetgeek opened this issue Jan 30, 2019 · 10 comments
Closed

Security vulnerabilities in dependency "jsrsasign" #743

dotnetgeek opened this issue Jan 30, 2019 · 10 comments
Labels

Comments

@dotnetgeek
Copy link

dotnetgeek commented Jan 30, 2019

Hi,

we are using the oicd-client-js component in your SPA Application and one of our security scan reported a vulnerability because of YUI. YUI 2.9.0 seems to have some vulnerabilities, as reported here:

https://www.cvedetails.com/vulnerability-list/vendor_id-290/product_id-20206/version_id-137803/Yahoo-YUI-2.9.0.html

After investigation I see that this Issue is related to kjur/jsrsasign#140. Is there a way to remove / replace jsrsasign?

Thanks,
Daniel

@brockallen
Copy link
Member

Yes, I'd love to ditch it but I'm not getting a lot of support on the PR: #639. The author of jsrsasign indicated that his lib is not using the affected features.

@brockallen
Copy link
Member

Closing. If you still have issues or find that the affected component is being used, feel free to reopen.

@subesokun
Copy link

@brockallen Retire.js still reports this vulnerability. Should I ignore it or was this issue fixed already in some version?

YUI 2.9.0 has known vulnerabilities: severity: high; CVE: CVE-2012-5883; http://www.cvedetails.com/cve/CVE-2012-5883/ severity: high; CVE: CVE-2012-5882; http://www.cvedetails.com/cve/CVE-2012-5882/ severity: high; CVE: CVE-2012-5881; http://www.cvedetails.com/cve/CVE-2012-5881/
/.../node_modules/oidc-client/dist/oidc-client.min.js

@brockallen
Copy link
Member

Same answer as before.

@subesokun
Copy link

subesokun commented Nov 13, 2019

Ok, I see. The library might not use the affected features but still our vulnerability scanner complains about it. As the YUI lib is affected by multiple CVE's, this is adding quite some noise on our security dashboard. Currently, there are 50+ warnings across our apps which we need to manually review and whitelist :(

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-5881
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-5882
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-5883

@brockallen
Copy link
Member

Eventually when I have time, I will work on a 2.0 that no longer uses that library.

@brockallen
Copy link
Member

Also, I think their use of yui is just in their build tooling.

@BiancaArtola
Copy link

Ey! I am having the same vulnerability on my projects. Will be any updates?

@ux-engineer
Copy link

ux-engineer commented May 26, 2021

Eventually when I have time, I will work on a 2.0 that no longer uses that library.

@brockallen this problem still exists. I have installed oidc-client package via NPM and this vulnerable code snippet gets into build bundle, raising flags with security auditing tools.

Are there plans for 2.0 without this dependency included?

@brockallen
Copy link
Member

Once we remove implicit flow, yes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

5 participants