Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring the signature algorithm with HTTP post #115

Closed
orf opened this issue Nov 17, 2017 · 2 comments
Closed

Add support for configuring the signature algorithm with HTTP post #115

orf opened this issue Nov 17, 2017 · 2 comments

Comments

@orf
Copy link

orf commented Nov 17, 2017

Support for customizing the signature algorithm with HTTP redirects was added here: 441b8d1

However there is no support for customising the algorithm with HTTP posts. The only workaround is to do this:

from saml2 import xmldsig
xmldsig.sig_default = xmldsig.SIG_RSA_SHA512

Is it possible to add support for customising the signature algorithm with HTTP post bindings as well? It seems quite simple, I can perhaps add support for it in a merge request if it is as simple as I think it is.

@peppelinux
Copy link
Member

peppelinux commented Jun 25, 2018

Discussion about this in pysaml2 repository is here:
IdentityPython/pysaml2#495

It could be a usefull to introduce it directly in pysaml2 configuration manager.

@peppelinux
Copy link
Member

Following the pySAML2 PR and the latest contributions in what will have as the v0.18.2 release, we got this problem fixed, please let us know if you think that we could also improve the actual approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants