Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

[Suggestion] HtmlResult/AssetManager.GetLayoutHtml+ abstraction #178

Closed
rayph opened this issue Jun 27, 2014 · 4 comments
Closed

[Suggestion] HtmlResult/AssetManager.GetLayoutHtml+ abstraction #178

rayph opened this issue Jun 27, 2014 · 4 comments
Assignees
Milestone

Comments

@rayph
Copy link

rayph commented Jun 27, 2014

I have been following IdSrv with great interest for a while now and the new v3 architecture is looking really good for a 1st preview.

My suggestion expands on #164 but would enable a deeper customisation, rather than only making the existing html/assets customisable I'd like to see the currently static AssetManager abstracted out so completely bespoke view/model rendering can be injected. This would enable folks to plug in their own presentation layer+asset management while still getting the benefit of all the logic and protocol handling in core.

From what I can see it should be quite straightfoward to pull an interface out for AssetManager and have the desired or default implementation added to the container via a PluginConfiguration property. All members of AssetManager could be more loosely coupled and customisable.

Forgive me if this is already being planned, or if not what do you think of this as a feature?

@brockallen
Copy link
Member

Thanks for the suggestion. We'll see what we can do. Thanks.

@brockallen
Copy link
Member

Ok, this was added. I'd love feedback if/when you have time. Thx.

@rayph
Copy link
Author

rayph commented Jul 24, 2014

Looks great! Just had a look at the latest code and I like the approach. It even looks possible to augment the view models to enrich the views beyond the vanilla feature set. Wonderful stuff.

Which makes me wonder; what sorts of things will appear in the environment dictionary? I'm hoping for something about the relying party / request origin to be available to the view service :)

I'll experiment with plugging in a different view engine pretty soon and will let you know how the implementation feels.

Thanks for getting this onto the backlog and into code this quickly!

@brockallen
Copy link
Member

The env dictionary is the owin environment in case something from the request was needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants