Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

'Submit this form' page customization #2124

Closed
mirkolugano opened this issue Nov 5, 2015 · 20 comments
Closed

'Submit this form' page customization #2124

mirkolugano opened this issue Nov 5, 2015 · 20 comments
Assignees
Milestone

Comments

@mirkolugano
Copy link

I would like to change the 'Submit this form' document.title property of the temporary response page (and maybe add a loading gif) I get after the authentication but if I got it right that's not possible with the usual templates/page.html overwrite feature. It's not a real problem, since the page disappears very quickly, it would just be a nice-to-have feature. Is it possible? Thanx.

@brockallen
Copy link
Member

Hmm, ok... I guess we can think about how to make that configurable.

@mikeandersun
Copy link

👍

2 similar comments
@dcinzona
Copy link

👍

@scottbrady91
Copy link
Member

👍

@brockallen brockallen self-assigned this Nov 19, 2015
@cbomkamp
Copy link

👍

This page doesn't always disappear quickly. For example, if the client application was just deployed/updated, it can take several seconds for it to "spin up" so any user who happens to login at that time are stuck on this completely blank page for several seconds.

@streicherm
Copy link

👍

4 similar comments
@davebown
Copy link

davebown commented Dec 8, 2015

+1

@lyntondicks
Copy link

+1

@JesseKlaasse
Copy link

+1

@somak12
Copy link

somak12 commented Dec 11, 2015

👍

@brockallen
Copy link
Member

So should this be a new service, an addition to the current view service (breaking change), just a string somewhere in the config system for the name of the custom file, or a file in the ~/templates discovered by convention?

@brockallen brockallen added this to the 2.3 milestone Dec 11, 2015
@davebown
Copy link

For me either a string in the config system or a custom template discovered by convention would suffice. Obviously the latter would allow more flexibility and snazzy animations as suggested at the start of the thread. ;-)

@dcinzona
Copy link

Config string or file in Templates works for me.

@mirkolugano
Copy link
Author

I would also prefer a file in the Templates folder for more flexibility as davebown suggests

@leastprivilege leastprivilege modified the milestones: 2.4, 2.3 Dec 19, 2015
@brockallen
Copy link
Member

Ok, I've done something towards this request.

If you're using the DefaultViewService (or a derived class) then there's a new view that can be used called "authorizeresponse" and it works like all the other views (in terms of customization, partial vs. full, and the "templates" folder). I did it this way since it seemed to make sense to try to re-use as much of the existing logic to locate the template view folder, and re-use as much of the layout customization that people might have already built.

This new view is used from some special casing code in the authorization response logic and was done this way as to not introduce breaking changes in this release. In the 3.0 time frame a more formal API will be added to the view service interface so people not using the DefaultViewService will also be able to replace it.

Please have a look on the myget feed/dev branch and provide feedback. I'll also add a new sample to show how to use it.

Thanks.

@dcinzona
Copy link

dcinzona commented Jan 17, 2016 via email

@somak12
Copy link

somak12 commented Jan 19, 2016

Hi @brockallen when can we expect this feature in case of Custom ViewService? I guess you mentioned 3.0 release. Can you give an estimate of 3.0 release? For now is there any way to do this?

@brockallen
Copy link
Member

In 2.4 in theory you could derive from the DefaultViewService to get this behavior.

@ManojShenoy25
Copy link

@brockallen : Is there any documentation or sample to configure the document title for the "Submit this form" page?

@brockallen
Copy link
Member

Only what you see above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests