Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

Better errors for invalid requests #3702

Open
lukos opened this issue May 22, 2017 · 0 comments
Open

Better errors for invalid requests #3702

lukos opened this issue May 22, 2017 · 0 comments

Comments

@lukos
Copy link

lukos commented May 22, 2017

We have many developers who are new to oidc and who are trying to configure a plugin to use our site with idsrv but several errors all return the same thing, making it hard to distinguish real errors from user errors.

For instance, client.Enabled == false, IsRedirectUriValidAsync() == false, request.Flow != Client.Flow and !AreScopesValid() all produce the error, "The client application is not known or is not authorized.", which I believe is both misleading and unhelpful.

Many people will call the IdP with the wrong redirect uri and be told the client is not authorized, which is not strictly true and which doesn't help them fix their problem.

Is it OK for me to submit a PR that distinguishes these errors more specifically so that the ViewService can choose to show different messages or pages to the user to help them fix their problem?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants