Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text added to the wrong place when autocomplete is active #1183

Open
felipeerias opened this issue Jan 17, 2024 · 2 comments
Open

Text added to the wrong place when autocomplete is active #1183

felipeerias opened this issue Jan 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@felipeerias
Copy link
Contributor

Configuration

Wolvic version: 1.5.2

Steps to Reproduce

  1. Click on the URL bar or on a text field on the webpage
  2. Enter a few characters, so autocomplete starts suggesting words
  3. Click on another position on the same text field
  4. Enter another character

Current Behavior

The character is appended to the last location where text was entered, not to where the cursor is.

@felipeerias
Copy link
Contributor Author

felipeerias commented Jan 17, 2024

Video:

trim.1798B2A3-ACA1-44E0-9E0B-36B885E5B806.MOV

@HollowMan6 HollowMan6 self-assigned this Jan 17, 2024
@HollowMan6 HollowMan6 added the bug Something isn't working label Jan 17, 2024
@HollowMan6
Copy link
Collaborator

HollowMan6 commented Jan 18, 2024

To fix this, we need to implement our own InputMethodService and override onUpdateSelection to make all these possible https://developer.android.com/reference/android/inputmethodservice/InputMethodService#onUpdateSelection(int,%20int,%20int,%20int,%20int,%20int) , which is not so straightforward to fix.

I also tried to use the patch to commit composing once moving cursor in web pages, but since we use postInputCommand here, the position of the cursor will change, causing this to fail.

b7598dc

@HollowMan6 HollowMan6 added enhancement New feature or request and removed enhancement New feature or request bug Something isn't working labels Jan 18, 2024
@felipeerias felipeerias added bug Something isn't working and removed enhancement New feature or request labels Jan 24, 2024
@HollowMan6 HollowMan6 removed their assignment Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants