Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize deprecated JobIntentService #805

Open
HollowMan6 opened this issue Jul 4, 2023 · 2 comments · May be fixed by #259
Open

Modernize deprecated JobIntentService #805

HollowMan6 opened this issue Jul 4, 2023 · 2 comments · May be fixed by #259
Labels
dependencies Pull requests that update a dependency file priority-low

Comments

@HollowMan6
Copy link
Collaborator

JobIntentService class has been deprecated in favor of the Android Jetpack WorkManager library, which makes it easy to schedule deferrable, asynchronous tasks that are expected to run even if the app exits or the device restarts.

Location

https://github.com/Igalia/wolvic/pull/787/files#diff-cbdf699b99d52ca4542d0bee4bd712ad3de1531c130a28fe5c54d29f28fa36f5R10

Possible Solution

As suggested in:
@svillar svillar added good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Jul 4, 2023
@HollowMan6
Copy link
Collaborator Author

JobIntentService is now only used in crash reports. So this issue and anything related to crash report can be solved in combination with this PR as a whole: #259

@HollowMan6 HollowMan6 removed the good first issue Good for newcomers label Aug 2, 2023
@HollowMan6
Copy link
Collaborator Author

Replacing JobIntentService with WorkManager for crash reports is currently not possible since the handlerService parameter for CrashHandler must be something that extends Service in gecko upstream: https://github.com/mozilla/gecko-dev/blob/6dd16cb77552c7cec8ab7e4e3b74ca7d5e320339/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/CrashHandler.java#L99

@HollowMan6 HollowMan6 linked a pull request Oct 1, 2023 that will close this issue
Do not instantiate the Runtime in crash reporter service #259
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file priority-low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not instantiate the Runtime in crash reporter service Igalia/wolvic
2 participants
@svillar @HollowMan6