Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime picker prompt dialog is not properly triggered #896

Closed
HollowMan6 opened this issue Aug 8, 2023 · 6 comments · Fixed by #917
Closed

DateTime picker prompt dialog is not properly triggered #896

HollowMan6 opened this issue Aug 8, 2023 · 6 comments · Fixed by #917
Labels
bug Something isn't working

Comments

@HollowMan6
Copy link
Collaborator

Configuration

Wolvic version: main
Wolvic build ID:

Hardware: Should be hardware-agnostic, at least in Meta Quest 2

Steps to Reproduce

  1. Open https://people.igalia.com/femorandeira/input/
  2. Click on the date/time input
  3. Complete the date/time picker prompt dialog
  4. Click on the same input again

Current Behavior

The dateTime picker prompt dialog is not triggered again, the only way to get the dateTime picker prompt dialog show again is to re-focus the input (click on anywhere outside of the input to make the input lose focus, and then click on the input to make it get focused again)

Expected Behavior

The dateTime picker prompt dialog should get triggered every time we click on the input.

Possible Solution

It's still not clear what caused this.

Context

Previous investigation suggests that it is caused by onDateTimePrompt() not properly called. So maybe some issue related to the gecko.

Error Logs and Stack Traces

@HollowMan6 HollowMan6 added the bug Something isn't working label Aug 8, 2023
@svillar
Copy link
Member

svillar commented Aug 8, 2023

Question is, does it only happen with date inputs? I guess it happens also with file pickers?

@HollowMan6
Copy link
Collaborator Author

Question is, does it only happen with date inputs? I guess it happens also with file pickers?

I think it doesn't happen with file pickers, since the button isn't focused after we make the choice. So far, I think it only happens with date/time inputs.

@HollowMan6
Copy link
Collaborator Author

I think at least it can be a fix if we make the date/time inputs unfocused after we complete the picker dialog, but I'm not sure how since the only thing we can work on is the callback (onDateTimePrompt())

@HollowMan6
Copy link
Collaborator Author

Now I can confirm this is purely a gecko issue, as I can reproduce the exact same issue as here in Firefox Android using my Android phone: https://apkcombo.com/firefox/org.mozilla.firefox/old-versions/105.1.0/

So close this.

@HollowMan6
Copy link
Collaborator Author

This should be fixed when we upgrade to a later version of gecko, as I can see it's fixed in latest version.

@HollowMan6
Copy link
Collaborator Author

Reopen and to be closed together with #917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants