Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panes have an additional header when dragging them from a tab #26

Open
kdinev opened this issue Apr 27, 2022 · 1 comment
Open

Panes have an additional header when dragging them from a tab #26

kdinev opened this issue Apr 27, 2022 · 1 comment
Assignees
Labels
bug Something isn't working status: in-review

Comments

@kdinev
Copy link
Member

kdinev commented Apr 27, 2022

Description

When undock (start dragging) a docked pane in a tab, the floating pane has two headers.

  • version: 1.7.0
  • browser: all

Steps to reproduce

  1. Open https://www.infragistics.com/products/ignite-ui-angular/angular/components/dock-manager
  2. Start dragging "Document 2"

Result

The "Document 2" pane has two headers.

Expected result

There should be only one header

Attachments

image

@onlyexeption
Copy link
Contributor

When rendering a floating pane, a pane header gets rendered on top of it so we can handle the whole document host dragging/closing. If we remove it, we should either change the tabs component so it can support drag events or change the pane header to support rendering tab headers inside it. Since both scenarios will require a lot of changes, testing and potential introduction of bugs, here's a proposition that wouldn't require any big changes but will still resolve this issue.

  1. Remove the maximize icon from the tab strip area.
  2. Display the active pane's name in the pane header.
  3. Add margin around the split pane.

image

FYI, VS has a similar way of handling this scenario:

image

@kdinev, @sdimchevski let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: in-review
Projects
None yet
Development

No branches or pull requests

3 participants