Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio Group: Radio Buttons are not unchecked when another is checked #938

Closed
teodosiah opened this issue Oct 4, 2023 · 5 comments
Closed
Labels
🆕 status: new The issue is new and will be reviewed when somebody picks it up. radio radio-group status: by-design status: not-a-bug

Comments

@teodosiah
Copy link
Contributor

Description

When a radio button is checked, the previously checked button is not unchecked.

version: 4.4.0

Steps to reproduce

  1. Click on some radio button
  2. Click on another button

Result

wc-radio-issue

Expected result

wc-radio-expected

Note: The issue is not reproducible in the Storybook

@teodosiah teodosiah added bug Something isn't working 🆕 status: new The issue is new and will be reviewed when somebody picks it up. radio radio-group labels Oct 4, 2023
@rkaraivanov
Copy link
Member

@teodosiah
Do you have a sample reproducing the issue?

@teodosiah
Copy link
Contributor Author

@rkaraivanov
Copy link
Member

I would not consider this a bug per se, since radio groups (not the component) are a set
of radio inputs that share the same name attribute (link).

Here is the updated sample:

Edit igc-radio-group-wc-4.4.0-issue (forked)

@rkaraivanov rkaraivanov added status: not-a-bug status: by-design and removed bug Something isn't working labels Oct 5, 2023
@rkaraivanov
Copy link
Member

@teodosiah
Maybe we should update the samples to reflect that?

@teodosiah
Copy link
Contributor Author

I will log it in the samples repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 status: new The issue is new and will be reviewed when somebody picks it up. radio radio-group status: by-design status: not-a-bug
Projects
None yet
Development

No branches or pull requests

2 participants