Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gp_standard needs deleting #46

Closed
IhsanKhaliq opened this issue Feb 16, 2021 · 1 comment
Closed

gp_standard needs deleting #46

IhsanKhaliq opened this issue Feb 16, 2021 · 1 comment
Assignees

Comments

@IhsanKhaliq
Copy link
Owner

https://github.com/IhsanKhaliq/Ascotracer/blob/087e9d485b495bdf49f0a611277c4dfbbdb62aa6/R/trace_asco.R#L153

There is no gp_standard in the original model, and its value (40) has already been assigned to the min_gp'. P.s. If minimum growing points per day are 350 and maximum growing points per square metre are 15000, then 40 doesn't seem the right value for gp_standard`

@PaulMelloy
Copy link
Collaborator

PaulMelloy commented Feb 16, 2021

Please don't delete, I renamed this variable in the data.table to consolidate a number of other parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants