Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect position of SharedElement in inverted Flatlist #72

Closed
waroulolz opened this issue Jun 11, 2020 · 5 comments
Closed

Incorrect position of SharedElement in inverted Flatlist #72

waroulolz opened this issue Jun 11, 2020 · 5 comments
Labels
android bug Something isn't working

Comments

@waroulolz
Copy link

Hi,
I have an shared element image displayed in each item of my flatlist. On click it transitions nicely to another view with the same shared element image.

However, if I add inverted={true} to my flatlist, the transition animations doesn't happen... while the debug mode is showing the correct start/end nodes.

<FlatList
        data={listData}
        initialNumToRender={6}
        renderItem={renderItem}
        keyExtractor={(item) => item.uuid}
        inverted={true}
      />
@waroulolz waroulolz changed the title SharedElement in inverted Flatlist not working [Bug] SharedElement in inverted Flatlist not working Jun 19, 2020
@waroulolz waroulolz changed the title [Bug] SharedElement in inverted Flatlist not working [v5] SharedElement in inverted Flatlist not working Jul 7, 2020
@waroulolz
Copy link
Author

It seems to me that the target destination is also "inverted", so with a small Flatlist, you can see part of the animation going to a totally offset location.

@mahsakhoomohammadi
Copy link

@wcandillon
What is your opinion on this issue?

@IjzerenHein IjzerenHein changed the title [v5] SharedElement in inverted Flatlist not working Incorrect position of SharedElement in inverted Flatlist Aug 19, 2021
@IjzerenHein IjzerenHein transferred this issue from IjzerenHein/react-navigation-shared-element Aug 19, 2021
@IjzerenHein
Copy link
Owner

As far as I'm aware, this problem affects the Android implementation. The layout for inverted ScrollViews is not obtained correctly causing weird position and clipping issues.

@IjzerenHein IjzerenHein added the bug Something isn't working label Aug 19, 2021
@p-syche
Copy link
Collaborator

p-syche commented Jan 26, 2023

This issue has been open a while ago. I checked it today in the example app and I couldn't see the bug.
@waroulolz can you take a look at the video and let me know if that's the expected behavior?

shared_inverted.mp4

@p-syche
Copy link
Collaborator

p-syche commented Mar 31, 2023

I'm closing this issue because I wasn't able to reproduce and the author is not responding.

@p-syche p-syche closed this as completed Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants