New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof of concept: Integrate httpgd #614
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I love this! |
ManuelHentschel
changed the title
WIP/Proof of concept: Integrate httpgd
Proof of concept: Integrate httpgd
Apr 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: To make styling easier, I've removed some hardcoded styles in a fork of httpgd.
The viewer now contains a very rudimentary plot history, which highlights a plot on hover
but does not do anything elseand lets the user select a plotWhat problem did you solve?
This PR contains a very basic integration of httpgd to display plots.
A big advantage of the SVG format used here is that it can be styled using the CSS variables provided by vscode.
Between the two screenshots below, only the color theme and font family (in vscode's settings) were changed, the plot updated automatically.
The added typescript code is mostly just copied from here.
Screenshots:
How can I check this pull request?
Install httpgd from this branch, copy the following code to your
.Rprofile
and callplotTest()
in an R terminal created by the extension.cc: @nx10, @renkun-ken