Merge be6679e into 65278d3

weni-ai · Oct 25, 2018 · 2b3d870 · 2b3d870
2 parents 65278d3 + be6679e
commit 2b3d870
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/bothub/common/models.py b/bothub/common/models.py
@@ -460,6 +460,9 @@ def ready_for_train(self):
         if self.training_started_at:
             return False
 
+        if len(self.requirements_to_train) > 0:
+            return False
+
         previous_update = self.repository.updates.filter(
             language=self.language,
             by__isnull=False,

diff --git a/bothub/common/tests.py b/bothub/common/tests.py
@@ -767,7 +767,8 @@ def setUp(self):
             owner=self.owner,
             name='Test',
             slug='test',
-            language=languages.LANGUAGE_EN)
+            language=languages.LANGUAGE_EN,
+            use_language_model_featurizer=False)
 
     def test_be_true(self):
         RepositoryExample.objects.create(
@@ -871,6 +872,19 @@ def test_entity_dont_have_min_examples(self):
             entity='hi')
         self.assertTrue(self.repository.current_update().ready_for_train)
 
+    def test_settings_change_exists_requirements(self):
+        self.repository.current_update().start_training(self.owner)
+        self.repository.use_language_model_featurizer = True
+        self.repository.save()
+        RepositoryExample.objects.create(
+            repository_update=self.repository.current_update(),
+            text='hello',
+            intent='greet')
+        self.assertEqual(
+            len(self.repository.current_update().requirements_to_train),
+            1)
+        self.assertFalse(self.repository.current_update().ready_for_train)
+
     def test_no_examples(self):
         example = RepositoryExample.objects.create(
             repository_update=self.repository.current_update(),