Skip to content

Commit

Permalink
remove delete and pre_delete tasks and signals as they're doesn't wor…
Browse files Browse the repository at this point in the history
…k well with celery
  • Loading branch information
helllllllder committed Nov 8, 2021
1 parent 4b70378 commit 2d717c6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 38 deletions.
10 changes: 5 additions & 5 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@ djangorestframework-recaptcha = "~=0.2.0"
djangogrpcframework = "~=0.2.1"
grpcio = "~=1.39.0"
grpcio-tools = "~=1.39.0"
django-elasticsearch-dsl= "~=7.2.0"
django-elasticsearch-dsl-drf= "~=0.22.1"
elasticsearch= "~=7.14.0"
elasticsearch-dsl= "~=7.4.0"
django-elasticsearch-dsl = "~=7.2.0"
django-elasticsearch-dsl-drf = "~=0.22.1"
elasticsearch = "~=7.14.0"
elasticsearch-dsl = "~=7.4.0"
psycopg2-binary = "~=2.9.1"
weni-protobuffers = "~=1.2.1"

[dev-packages]
"flake8" = "~=4.0.0"
flake8 = "~=4.0.0"
requests-mock = "~=1.8.0"
coverage = "~=5.5"
ipython = "*"
Expand Down
19 changes: 0 additions & 19 deletions bothub/common/signals.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,3 @@ def handle_save(self, sender, instance, **kwargs):
"es_handle_save", args=[instance.pk, app_label, model_name]
)
)

def handle_pre_delete(self, sender, instance, **kwargs):
app_label = instance._meta.app_label
model_name = instance._meta.model_name
model = instance._meta.concrete_model
if model in registry._models or model in registry._related_models:
celery_app.send_task(
"es_handle_pre_delete", args=[instance.pk, app_label, model_name]
)

def handle_delete(self, sender, instance, **kwargs):
# app_label = instance._meta.app_label // NOSONAR
# model_name = instance._meta.model_name // NOSONAR
# model = instance._meta.concrete_model // NOSONAR
# if model in registry._models or model in registry._related_models: // NOSONAR
# celery_app.send_task( // NOSONAR
# "es_handle_delete", args=[instance.pk, app_label, model_name] // NOSONAR
# ) // NOSONAR
pass
14 changes: 0 additions & 14 deletions bothub/common/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,20 +48,6 @@ def handle_save(pk, app_label, model_name):
registry.update_related(instance)


@app.task(name="es_handle_pre_delete")
def handle_pre_delete(pk, app_label, model_name):
sender = apps.get_model(app_label, model_name)
instance = sender.objects.get(pk=pk)
registry.delete_related(instance)


@app.task(name="es_handle_delete")
def handle_delete(pk, app_label, model_name):
sender = apps.get_model(app_label, model_name)
instance = sender.objects.get(pk=pk)
registry.delete(instance, raise_on_error=False)


@app.task()
def trainings_check_task():
trainers = RepositoryQueueTask.objects.filter(
Expand Down

0 comments on commit 2d717c6

Please sign in to comment.