Skip to content

Commit

Permalink
[fix] Tests
Browse files Browse the repository at this point in the history
  • Loading branch information
dyohan9 committed Oct 8, 2019
1 parent a98096e commit 9a4deb7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 9 additions & 0 deletions bothub/api/v2/repository/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ class Meta:
model = RequestRepositoryAuthorization
fields = [
"id",
"user",
"user__nickname",
"repository",
"text",
"approved_by",
Expand All @@ -43,12 +45,18 @@ class Meta:
repository = serializers.PrimaryKeyRelatedField(
queryset=Repository.objects, style={"show": False}, required=False
)
user = serializers.HiddenField(
default=serializers.CurrentUserDefault(), style={"show": False}
)
text = TextField(
label=_("Leave a message for repository administrators"),
min_length=5,
max_length=RequestRepositoryAuthorization._meta.get_field("text").max_length,
required=False,
)
user__nickname = serializers.SlugRelatedField(
source="user", slug_field="nickname", read_only=True
)
approved_by__nickname = serializers.SlugRelatedField(
source="approved_by", slug_field="nickname", read_only=True
)
Expand All @@ -57,6 +65,7 @@ class Meta:
)

def update(self, instance, validated_data):
validated_data.pop('user')
validated_data.update({"approved_by": self.context["request"].user})
return super().update(instance, validated_data)

Expand Down
2 changes: 1 addition & 1 deletion bothub/common/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ def test_approve(self):
self.ra.approved_by = self.owner
self.ra.save()
user_authorization = self.ra.repository.get_user_authorization(self.ra.user)
self.assertEqual(user_authorization.usergrouprepository.name, "Public")
self.assertEqual(user_authorization.usergrouprepository.name, "Contributor")

def test_approve_twice(self):
self.ra.approved_by = self.owner
Expand Down

0 comments on commit 9a4deb7

Please sign in to comment.