Skip to content

Commit

Permalink
Merge 4b570af into c108169
Browse files Browse the repository at this point in the history
  • Loading branch information
Douglas Paz committed Oct 24, 2018
2 parents c108169 + 4b570af commit a9200c7
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
3 changes: 3 additions & 0 deletions bothub/common/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,9 @@ def ready_for_train(self):
not self.deleted.exists():
return False

if self.examples.count() == 0:
return False

return len(self.requirements_to_train) is 0

@property
Expand Down
9 changes: 9 additions & 0 deletions bothub/common/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,15 @@ def test_entity_dont_have_min_examples(self):
entity='hi')
self.assertTrue(self.repository.current_update().ready_for_train)

def test_no_examples(self):
example = RepositoryExample.objects.create(
repository_update=self.repository.current_update(),
text='hi',
intent='greet')
self.repository.current_update().start_training(self.owner)
example.delete()
self.assertFalse(self.repository.current_update().ready_for_train)


class RequestRepositoryAuthorizationTestCase(TestCase):
def setUp(self):
Expand Down

0 comments on commit a9200c7

Please sign in to comment.