Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to minimal train #207

Merged
merged 4 commits into from
Sep 26, 2018
Merged

Add validation to minimal train #207

merged 4 commits into from
Sep 26, 2018

Conversation

dougppaz
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 21, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1048

  • 34 of 38 (89.47%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 95.497%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bothub/common/models.py 34 38 89.47%
Files with Coverage Reduction New Missed Lines %
bothub/api/validators.py 1 88.68%
Totals Coverage Status
Change from base Build 1038: -0.3%
Covered Lines: 1527
Relevant Lines: 1599
💛 - Coveralls

@dougppaz dougppaz merged commit 0d6a7ea into develop Sep 26, 2018
@dougppaz dougppaz deleted the rasa-validate branch September 26, 2018 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edudouglas edudouglas edudouglas approved these changes

@johncordeiro johncordeiro Awaiting requested review from johncordeiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dougppaz @coveralls @edudouglas