Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new field for names prediction #247

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Add new field for names prediction #247

merged 4 commits into from
Mar 28, 2019

Conversation

johncordeiro
Copy link
Contributor

This feature is connected to Bothub NLP, which uses this parameter to include ner_spacy to the processing pipeline.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1278

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 95.93%
Totals Coverage Status
Change from base Build 1265: 0.006%
Covered Lines: 3465
Relevant Lines: 3612
💛 - Coveralls

cristophersfr
cristophersfr approved these changes Mar 28, 2019
View reviewed changes
Copy link

@cristophersfr cristophersfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems okay to me, the tests are working and the code is following PEP8.
The modifications are reasonable and clean.

@johncordeiro johncordeiro merged commit 0af5bc0 into develop Mar 28, 2019
@johncordeiro johncordeiro deleted the feature/ner-spacy branch April 3, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristophersfr cristophersfr cristophersfr approved these changes

@edudouglas edudouglas edudouglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johncordeiro @coveralls @cristophersfr @edudouglas