Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/edit sentence #252

Merged
merged 4 commits into from
Jul 5, 2019
Merged

Feature/edit sentence #252

merged 4 commits into from
Jul 5, 2019

Conversation

dyohan9
Copy link
Contributor

@dyohan9 dyohan9 commented Jun 17, 2019

No description provided.

@dyohan9 dyohan9 added the enhancement New feature or request label Jun 17, 2019
@dyohan9 dyohan9 self-assigned this Jun 17, 2019
@dyohan9 dyohan9 changed the base branch from master to feature/evaluate June 17, 2019 14:22
@dyohan9 dyohan9 changed the base branch from feature/evaluate to develop June 17, 2019 14:24
@coveralls
Copy link

coveralls commented Jun 17, 2019

Pull Request Test Coverage Report for Build 1344

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 92.939%

Totals Coverage Status
Change from base Build 1330: 0.05%
Covered Lines: 3751
Relevant Lines: 4036

💛 - Coveralls

"""
queryset = RepositoryExample.objects
serializer_class = RepositoryExampleSerializer
permission_classes = [
RepositoryExamplePermission,
]

def perform_update(self, serializer):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method "perform_update" is necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not necessary, i will remove @edudouglas

@VictorMeneghini VictorMeneghini merged commit c92c08d into develop Jul 5, 2019
@VictorMeneghini VictorMeneghini deleted the feature/edit_sentence branch July 8, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants