Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refact bot_data, sending file to aws s3 #284

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Refact bot_data, sending file to aws s3 #284

merged 3 commits into from
Sep 19, 2019

Conversation

dyohan9
Copy link
Contributor

@dyohan9 dyohan9 commented Sep 2, 2019

No description provided.

@dyohan9 dyohan9 added the enhancement New feature or request label Sep 2, 2019
@dyohan9 dyohan9 self-assigned this Sep 2, 2019
@coveralls
Copy link

coveralls commented Sep 2, 2019 •
edited

Pull Request Test Coverage Report for Build 1703

  • 6 of 13 (46.15%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 96.089%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bothub/api/v2/nlp/views.py 2 9 22.22%
Files with Coverage Reduction New Missed Lines %
bothub/api/v2/nlp/views.py 2 56.83%
Totals Coverage Status
Change from base Build 1690: -0.09%
Covered Lines: 6020
Relevant Lines: 6265
💛 - Coveralls

Cloves23
Cloves23 reviewed Sep 10, 2019
View reviewed changes
bothub/common/views.py Outdated Show resolved Hide resolved
Cloves23
Cloves23 reviewed Sep 10, 2019
View reviewed changes
bothub/utils.py Outdated Show resolved Hide resolved
Cloves23
Cloves23 suggested changes Sep 10, 2019
View reviewed changes
Copy link

@Cloves23 Cloves23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use pk instead id when you need to get the primary key value.

@VictorMeneghini VictorMeneghini merged commit 1b43166 into develop Sep 19, 2019
@dyohan9 dyohan9 deleted the feature/refact_botdata branch September 19, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorMeneghini VictorMeneghini Awaiting requested review from VictorMeneghini

@Cloves23 Cloves23 Awaiting requested review from Cloves23

Assignees

@dyohan9 dyohan9

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dyohan9 @coveralls @Cloves23 @VictorMeneghini