Feature/grpc #550
Feature/grpc #550
Conversation
bothub/api/grpc/user/services.py
Outdated
|
|
||
| return serializer.message | ||
|
|
||
| def remove_user_permission(self, org: Organization, user: User, permission: str): |
There was a problem hiding this comment.
Couldn't that be a function outside the class? If you need to use this functionality elsewhere in the code, you will have to rewrite it, causing duplicate code
bothub/api/grpc/user/services.py
Outdated
| permissions = self.get_user_permissions(org, user) | ||
| permissions.delete() | ||
|
|
||
| def set_user_permission(self, org: Organization, user: User, permission: int): |
There was a problem hiding this comment.
Couldn't that be a function outside the class? If you need to use this functionality elsewhere in the code, you will have to rewrite it, causing duplicate code
bothub/utils.py
Outdated
| @@ -324,3 +351,54 @@ class CountSubquery(Subquery): | |||
|
|
|||
| def __init__(self, queryset, output_field=None, **extra): | |||
| super().__init__(queryset, output_field, **extra) | |||
|
|
|||
|
|
|||
| class AbstractService: | |||
There was a problem hiding this comment.
does it make sense to call yourself "Abstract Service"? since it implements specific methods? Perhaps it would be necessary to change the nomenclature.
Why is it called "Abstract" if it doesn't have any abstract methods?
bothub/utils.py
Outdated
| ) | ||
|
|
||
|
|
||
| class AbstractUserService(generics.GenericService): |
There was a problem hiding this comment.
the comments cited above are also replicated here
| grpc.StatusCode.NOT_FOUND, f"User:{request.user_email} not found!" | ||
| ) | ||
|
|
||
| def get_orgs(self, user: User): |
There was a problem hiding this comment.
Couldn't that be a function outside the class? If you need to use this functionality elsewhere in the code, you will have to rewrite it, causing duplicate code
| from bothub.protos import organization_pb2 | ||
|
|
||
|
|
||
| class SerializerUtils(object): |
There was a problem hiding this comment.
here you used Serializer at the beginning of the class, in the others you used it at the end of the name. It would be interesting to standardize
| key: value for key, value in data.items() if key not in ["id", "user_email"] | ||
| } | ||
|
|
||
| def _user_has_permisson(self, user: User, org: Organization) -> bool: |
There was a problem hiding this comment.
Couldn't that be a function outside the class? If you need to use this functionality elsewhere in the code, you will have to rewrite it, causing duplicate code
update max length nickname repository owner
|
SonarCloud Quality Gate failed.
|
No description provided.