Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a type error treatment in filter repository by org id #561

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

mldzs
Copy link
Contributor

@mldzs mldzs commented Mar 26, 2021

No description provided.

@mldzs mldzs requested a review from dyohan9 March 26, 2021 21:09
@coveralls
Copy link

coveralls commented Mar 26, 2021

Pull Request Test Coverage Report for Build 3649

  • 6 of 12 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 83.482%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bothub/api/v2/repository/filters.py 6 12 50.0%
Files with Coverage Reduction New Missed Lines %
bothub/api/v2/repository/filters.py 1 73.33%
Totals Coverage Status
Change from base Build 3642: -0.03%
Covered Lines: 3826
Relevant Lines: 4583

💛 - Coveralls


def filter_language(self, queryset, name, value):
return queryset.supported_language(value)

def filter_org_id(self, queryset, name, value):
owner = get_object_or_404(RepositoryOwner, org_id=value)
owner = get_object_or_404(RepositoryOwner, pk=value)
Copy link

@jcbalmeida jcbalmeida Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename filter_org_id to filter_owner_id

Copy link

@jcbalmeida jcbalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to rename org_id to owner_id and filter_org_id to filter_owner_id?

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mldzs mldzs merged commit 297a13f into develop Mar 29, 2021
@dyohan9 dyohan9 deleted the fix/filter_repository_by_org branch May 4, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants