Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor elasticsearch #698

Merged
merged 24 commits into from
Mar 4, 2022
Merged

Conversation

helllllllder
Copy link
Collaborator

@helllllllder helllllllder commented Feb 17, 2022

What

  • Ignore migration files when running black
  • Add a time_based variable to define if the document index is time_based
  • Overwrite search_index command to support creation on time based indices
  • Update README.md with the new variables
  • Update the tests using elasticsearch to delete the instance

Why

  • Fix the black conflict with sonarcloud
  • Solve the deletion problem with elasticsearch, as it wasn't deleting but taking the celery down
  • Elasticsearch does not delete the instances like the db when testing, so it needed to be done manually

@helllllllder helllllllder changed the base branch from master to develop February 17, 2022 19:47
@coveralls
Copy link

coveralls commented Feb 25, 2022

Pull Request Test Coverage Report for Build 4420

  • 36 of 38 (94.74%) changed or added relevant lines in 8 files are covered.
  • 35 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 79.602%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bothub/common/models.py 14 16 87.5%
Files with Coverage Reduction New Missed Lines %
bothub/common/models.py 35 90.07%
Totals Coverage Status
Change from base Build 4395: -0.3%
Covered Lines: 4156
Relevant Lines: 5221

💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@helllllllder helllllllder merged commit aaf4b4d into develop Mar 4, 2022
@helllllllder helllllllder deleted the feature/refactor_elasticsearch branch May 20, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants