Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry, Fix debug and Fix clone version #702

Merged
merged 13 commits into from
Mar 30, 2022

Conversation

helllllllder
Copy link
Collaborator

@helllllllder helllllllder commented Mar 23, 2022

What

  • Use Poetry instead of Pipenv 🥳
  • Update travis, docker files, makefile and README to use Poetry
  • Rename the clone task from debug_parse_text to clone_version
  • Use bulk_create instead of loops when possible at clone_version task
  • Update RepositoryVersionLanguage to have repository_version and language as unique_together.
  • Add RepositoryVersionLanguage query on RepositoryAuthorizationInfoViewSet

Why

  • Be free of pipenv
  • Solve a bug that appears when creating new versions, it was possible to create duplicates of a RepositoryVersionLanguage with the same repository_version and language.
  • Solve the debug endpoint, as it wasn't working with repository_version_language. Because of this, the debug functionality wasn't working properly. It was using only the default version of the repository, instead of using the repository_version_language that was passed in the request

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented Mar 24, 2022

Pull Request Test Coverage Report for Build 4447

  • 1 of 5 (20.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.621%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bothub/common/tasks.py 0 4 0.0%
Totals Coverage Status
Change from base Build 4421: 0.02%
Covered Lines: 4157
Relevant Lines: 5221

💛 - Coveralls

@helllllllder helllllllder changed the title Fix/double version language Add poetry, Fix debug and Fix clone version Mar 24, 2022
@helllllllder helllllllder merged commit 2113dc8 into develop Mar 30, 2022
@helllllllder helllllllder mentioned this pull request Apr 8, 2022
@helllllllder helllllllder deleted the fix/double_version_language branch May 20, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants