Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation Inconsistency Number bug #703

Merged
merged 7 commits into from
Apr 8, 2022
Merged

Translation Inconsistency Number bug #703

merged 7 commits into from
Apr 8, 2022

Conversation

helllllllder
Copy link
Collaborator

@helllllllder helllllllder commented Apr 1, 2022 •
edited
Loading

What

  • Update filter_has_invalid_entities and filter_has_valid_entities filter query as it wasn't working;
  • Refactor translate and examples filter, joining the equal code into a base function

Why

  • Fix the inconsistency number at the translation page

helllllllder and others added 2 commits March 31, 2022 20:42
@helllllllder
Took similar code between filter_has_valid_entities and filter_has_in…
2851b51 
…valid_entities and created a utils function filter_validate_entities

on filter_validate_entities, changed translations__entities__entity__in=F('entities__entity') into a new query as when it returns None or one instance the in lookup will break as it is not an iterable
@helllllllder
Merge branch 'develop' into fix/translation_inconsistency_number
8a91d28
@coveralls
Copy link

coveralls commented Apr 1, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 4456

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 79.915%
Files with Coverage Reduction New Missed Lines %
bothub/api/v2/examples/filters.py 1 84.21%
Totals Coverage Status
Change from base Build 4448: 0.3%
Covered Lines: 4126
Relevant Lines: 5163
💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@helllllllder helllllllder merged commit ae4dc4a into develop Apr 8, 2022
@helllllllder helllllllder mentioned this pull request Apr 8, 2022
Merged
@helllllllder helllllllder removed the request for review from Sandro-Meireles April 14, 2022 13:34
@helllllllder helllllllder deleted the fix/translation_inconsistency_number branch May 20, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlisoSouza AlisoSouza AlisoSouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@helllllllder @coveralls @AlisoSouza