Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL is assumed to not contain query parameters #115

Open
ncatelli opened this issue Apr 9, 2022 · 0 comments
Open

URL is assumed to not contain query parameters #115

ncatelli opened this issue Apr 9, 2022 · 0 comments

Comments

@ncatelli
Copy link

ncatelli commented Apr 9, 2022

The line https://github.com/Ilshidur/action-discord/blob/master/entrypoint.js#L67 appends a ?wait=true query string. This assumes that all provided URLS will not contain a query string. For most cases this is not a problem. However this does prevent some actions, such as posting into a thread from being possible via this plugin.

This might be resolvable by checking if the URL contains a ? and setting the parameter prefix accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant