Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building ImageMagick-Windows fails with Visual Studio 2017 #4441

Closed
cmb69 opened this issue Nov 4, 2021 · 2 comments
Closed

Building ImageMagick-Windows fails with Visual Studio 2017 #4441

cmb69 opened this issue Nov 4, 2021 · 2 comments

Comments

@cmb69
Copy link

cmb69 commented Nov 4, 2021

ImageMagick version

7.1.0-13

Operating system

Windows

Operating system, version and so on

Windows 10, Visual Studio 2017

Description

I'm trying to build ImageMagick via ImageMagick-Windows, and that works well with Visual Studio 2019, but fails with Visual Studio 2017 (15.9.40) with a long list of error messages like:

  d:\imagemagick-windows\highway\hwy\ops\generic_ops-inl.h(310): error C2938: "
hwy::N_AVX2::TFromD<unknown-type>": Spezialisierung der Aliasvorlage fehlgeschl
agen (Quelldatei wird kompiliert ..\..\jpeg-xl\lib\jxl\modular\encoding\enc_ma.
cc) [D:\ImageMagick-Windows\VisualMagick\jpeg-xl\CORE_jpeg-xl_DynamicMT.vcxproj
]
  d:\imagemagick-windows\highway\hwy\ops\generic_ops-inl.h(310): error C2955: "
hwy::IsSameT" : Für die Verwendung von Klasse Vorlage ist eine Vorlage-Argument
liste erforderlich (Quelldatei wird kompiliert ..\..\jpeg-xl\lib\jxl\modular\en
coding\enc_ma.cc) [D:\ImageMagick-Windows\VisualMagick\jpeg-xl\CORE_jpeg-xl_Dyn
amicMT.vcxproj]

If I exclude CORE_highway, CORE_jpeg-xl and IM_MOD_jxl projects from the build, the build succeeds (with several warnings, but that appears to be the same as with VS 2019).

Steps to Reproduce

Follow the build description in https://github.com/ImageMagick/ImageMagick-Windows#readme. Configuration is shown below (2nd page uses the default paths). Build with VS 2017 fails.

Images

Screenshot 2021-11-04 155632

@dlemstra
Copy link
Member

dlemstra commented Nov 4, 2021

It seems that an upgrade of the google highway library broke the VS2017 build. Doing another upgrade seems to have fixed it. This will become available in the next release.

@dlemstra dlemstra closed this as completed Nov 4, 2021
@cmb69
Copy link
Author

cmb69 commented Nov 5, 2021

I can confirm that ImageMagick/highway@a5b6622 fixes this issue. Thank you for the swift resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants